-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Mercurial (hg) support #197
Conversation
…ike a git) : Format is similar `git`-command: `haxelib hg libName urlToHg [branch] [subDir] [tag/revision]` * `haxelib hg mylib https://bitbucket.org/username/mylib` - HEAD of default branch; * `haxelib hg mylib https://bitbucket.org/username/mylib myBranch` - HEAD of myBranch; * `haxelib hg mylib https://bitbucket.org/username/mylib myBranch mySubDir myTag`
@@ -252,7 +254,7 @@ class Main { | |||
if (cats[i] == null) cats[i] = [c]; | |||
else cats[i].push(c); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for this? We eventually want to make haxelib usable as a library (see #186), so making this global seems a step in the wrong direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static public function ask( question )
Ok, I'll move it to something like Cli or CliUtil.
And print
& command
too.
This is a good start. Personally, I think it would be great if you could manage to abstract the VCS specific stuff away into the respective implementations, as far as possible (without jumping through hoops that is). More importantly: since this project is in such a lousy state, what would really help a lot is if you could include tests for this (ideally also for the case where the vcs in not available). |
@back2dos Thx for review. I'll update this branch and all will be beauty 💯%. |
Continue refactoring & unification for cvs.
I'll write tests soon. |
* fixed issue #196: Was: ``` $ mkdir temp; cd temp; rm -r ../temp; mkdir ../temp; haxelib upgrade shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory pwd: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory pwd: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory chdir: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory /usr/lib/haxe/std/neko/_std/Sys.hx:87: characters 2-24 : Error chdir upgrade tools/haxelib/Main.hx:309: characters 17-43 : Called from tools/haxelib/Main.hx:1508: characters 2-22 : Called from --macro:1: character 0 : Called from Aborted ``` Now works: ``` $ mkdir temp; cd temp; rm -r ../temp; mkdir ../temp; neko ./../haxelib.n upgrade; cd .. Main.hx:152: constructor: cwd_cache = "/Users/ak/Repositories/haxelib/bin/temp" Checking actuate Checking aether Checking air3 Checking arrowlets ... ```
… methods of Vcs.
I was break Git :(. I'll fix it. |
removed using `rm`
@back2dos : Ready for merge. Please review. |
It looks really quite good, but I currently cannot accept it yet, because of #204 As much as I like macros, I do think that what |
@back2dos OK? |
Indeed :) |
Merged by hand, as it conflicted with the symlink pull request. |
Oh, and thanks ;) |
Thank you. |
Remerge #197 + test and some fixes.
Implemented support for Mercurial (hg) : clone, diff, pull, update.
All behaviors for haxelib-cli look like similar for
haxelib git
-command.In the future it will help to support many any version control systems.
For test:
$ haxelib hg signal https://bitbucket.org/fzzr/hx.signal develop "" 0.9.2
and$ haxelib update signal
.