Skip to content

fixing compilation for adding surveyor to ping-cpp #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rileytuttle-havoc wants to merge 1 commit into
base: havoc-master
Choose a base branch
from
Draft

fixing compilation for adding surveyor to ping-cpp #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ def calc_payload(self, payloads):

return int(total_size)

def escape_reserved(self, name):
Copy link
Copy Markdown
Collaborator Author

@rileytuttle-havoc rileytuttle-havoc Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the surveyor message field names was "string" so it generated a string() function which is not allowed

reserved = {"string"}
ret_name = name + "_" if name in reserved else name
print(f'current name {name}: new name {ret_name}')
return ret_name
def should_convert_atof_to_string(self, type):
return type in "atof_point_data"

def convert_short_type(self, t):
# u/i
ui = t[0]
Expand Down Expand Up @@ -108,11 +116,11 @@ def get_printf_format(self, t):
'uint16_t': 'PRIu16',
'uint32_t': 'PRIu32',
'uint64_t': 'PRIu64',
'float': 'f',
Copy link
Copy Markdown
Collaborator Author

@rileytuttle-havoc rileytuttle-havoc Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think other devices never exercised this code. but the single quotes get stripped for these specifiers. thats alright for the macros above because they will get expanded. the f and d will not.

'double': 'f',
'float': '"f"',
'double': '"f"',
}
t = self.get_type_string(t)
return format_dict.get(t, 'd')
return format_dict.get(t, '"d"')

def is_vector(self, t):
return ('vector' in t)
Expand Down