fixing compilation for adding surveyor to ping-cpp#1
Draft
rileytuttle-havoc wants to merge 1 commit intohavoc-masterfrom
Draft
fixing compilation for adding surveyor to ping-cpp#1rileytuttle-havoc wants to merge 1 commit intohavoc-masterfrom
rileytuttle-havoc wants to merge 1 commit intohavoc-masterfrom
Conversation
|
|
||
| return int(total_size) | ||
|
|
||
| def escape_reserved(self, name): |
Collaborator
Author
There was a problem hiding this comment.
one of the surveyor message field names was "string" so it generated a string() function which is not allowed
| 'uint16_t': 'PRIu16', | ||
| 'uint32_t': 'PRIu32', | ||
| 'uint64_t': 'PRIu64', | ||
| 'float': 'f', |
Collaborator
Author
There was a problem hiding this comment.
I think other devices never exercised this code. but the single quotes get stripped for these specifiers. thats alright for the macros above because they will get expanded. the f and d will not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.