Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): Improve release scripts #689

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore(release): Improve release scripts #689

merged 1 commit into from
Nov 11, 2024

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Nov 11, 2024 •
edited
Loading

Acceptance Criteria

  1. Fails fast release.sh when team id is missing.
  2. Show latest git commit in log.
  3. Add the shasum_sign.sh script which generates the SHA256SUMS and SHA256SUMS.asc files.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@msbrogli msbrogli mentioned this pull request Nov 11, 2024
Closed
1 task
@msbrogli msbrogli force-pushed the chore/release-improvements branch from 20d23d2 to eda02cd Compare November 11, 2024 15:39
@msbrogli msbrogli self-assigned this Nov 11, 2024
@msbrogli msbrogli requested a review from tuliomir November 11, 2024 15:39
tuliomir
tuliomir approved these changes Nov 11, 2024
View reviewed changes
shasum-sign.sh Show resolved Hide resolved
@msbrogli msbrogli force-pushed the chore/release-improvements branch from 0ed9606 to bd832ac Compare November 11, 2024 17:13
@msbrogli msbrogli merged commit bd832ac into master Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@tuliomir tuliomir tuliomir approved these changes

Assignees

@msbrogli msbrogli

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbrogli @tuliomir @pedroferreira1