Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release.sh): Fails if the team id is missing #677

Closed
wants to merge 1 commit into from
Closed

chore(release.sh): Fails if the team id is missing #677

wants to merge 1 commit into from

Conversation

msbrogli
Copy link
Member

Acceptance Criteria

  1. Fails fast release.sh when team id is missing.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@msbrogli msbrogli self-assigned this Oct 30, 2024
@msbrogli msbrogli requested a review from tuliomir October 30, 2024 15:16
msbrogli
msbrogli commented Oct 30, 2024
View reviewed changes
release.sh
@@ -17,6 +17,11 @@ step0() {
echo - npm $(npm -v)
echo - python $(python --version | awk '{print $2}')
echo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add git log -n1 here.

@msbrogli
Copy link
Member Author

This PR was replaced by this: #689

@msbrogli msbrogli closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@tuliomir tuliomir tuliomir approved these changes

Assignees

@msbrogli msbrogli

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbrogli @tuliomir @pedroferreira1