Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check pin method #513

Merged
merged 16 commits into from
May 15, 2023
Merged

check pin method #513

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
291eb05
feat: check pin and password methods
r4mmer Apr 20, 2023
41decf1
chore: check pin and passwd on facade
r4mmer Apr 20, 2023
fe9e502
test: check pin and passwd facade tests
r4mmer Apr 20, 2023
036aba0
tests: remove expectation on number of times called
r4mmer Apr 20, 2023
f1adc8b
tests: await promises
r4mmer Apr 20, 2023
ba553d1
tests: check pin and passwd tests
r4mmer Apr 20, 2023
8ebf65b
feat: check password utility
r4mmer Apr 24, 2023
24c74f6
feat: utility to change pin from an access data
r4mmer Apr 25, 2023
5f6df1b
tests: change pin and password tests
r4mmer Apr 25, 2023
1a1d2a9
chore: review changes
r4mmer Apr 25, 2023
2078c15
tests: check invalid password
r4mmer Apr 25, 2023
260c6de
feat: add check pin method on wallet service facade
r4mmer Apr 28, 2023
6c25e63
chore: change pin to password
r4mmer May 10, 2023
4ae2d0a
chore: add acct path key to change pin util
r4mmer May 10, 2023
4b34308
chore: remove double import
r4mmer May 15, 2023
a7c559b
chore: check password with correct error
r4mmer May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: remove expectation on number of times called
  • Loading branch information
@r4mmer
r4mmer committed May 15, 2023
commit 036aba036cd2c20be6a9b13ccc51e1581f412215
26 changes: 5 additions & 21 deletions __tests__/new/hathorwallet.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ test('checkPin', async () => {

checkPinSpy.mockReturnValue(Promise.resolve(true));
await expect(hWallet.checkPin('0000')).resolves.toEqual(true);
expect(checkPinSpy).toHaveBeenCalledTimes(2);
expect(checkPinSpy).toHaveBeenCalledTimes(1);
});

test('checkPassword', async () => {
Expand Down Expand Up @@ -651,32 +651,16 @@ test('checkPinAndPassword', async () => {
checkPinSpy.mockReturnValue(Promise.resolve(false));
checkPasswdSpy.mockReturnValue(Promise.resolve(false));
await expect(hWallet.checkPinAndPassword('0000', 'passwd')).resolves.toEqual(false);
expect(checkPinSpy).toHaveBeenCalledTimes(1);
expect(checkPasswdSpy).toHaveBeenCalledTimes(0);
checkPinSpy.mockClear();
checkPasswdSpy.mockClear();

checkPinSpy.mockReturnValue(Promise.resolve(true));
checkPasswdSpy.mockReturnValue(Promise.resolve(false));
await expect(hWallet.checkPinAndPassword('0000', 'passwd')).resolves.toEqual(false);
expect(checkPinSpy).toHaveBeenCalledTimes(1);
expect(checkPasswdSpy).toHaveBeenCalledTimes(1);
checkPinSpy.mockClear();
checkPasswdSpy.mockClear();

checkPinSpy.mockReturnValue(Promise.resolve(true));
checkPasswdSpy.mockReturnValue(Promise.resolve(true));
await expect(hWallet.checkPinAndPassword('0000', 'passwd')).resolves.toEqual(true);
expect(checkPinSpy).toHaveBeenCalledTimes(1);
expect(checkPasswdSpy).toHaveBeenCalledTimes(1);
checkPinSpy.mockClear();
checkPasswdSpy.mockClear();

checkPinSpy.mockReturnValue(Promise.resolve(false));
checkPasswdSpy.mockReturnValue(Promise.resolve(true));
await expect(hWallet.checkPinAndPassword('0000', 'passwd')).resolves.toEqual(false);
expect(checkPinSpy).toHaveBeenCalledTimes(1);
expect(checkPasswdSpy).toHaveBeenCalledTimes(0);
checkPinSpy.mockClear();
checkPasswdSpy.mockClear();

checkPinSpy.mockReturnValue(Promise.resolve(true));
checkPasswdSpy.mockReturnValue(Promise.resolve(true));
await expect(hWallet.checkPinAndPassword('0000', 'passwd')).resolves.toEqual(true);
});