check pin method #513
Merged
check pin method #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #513 +/- ##
==========================================
+ Coverage 58.14% 58.26% +0.12%
==========================================
Files 66 66
Lines 5084 5106 +22
Branches 1049 1053 +4
==========================================
+ Hits 2956 2975 +19
- Misses 2040 2043 +3
Partials 88 88
|
r4mmer
force-pushed
the
feat/check-pin-method
branch
from
5eeccaa to
2593d10
Compare
r4mmer
requested review from
alexruzenhack
and removed request for
andreabadesso
alexruzenhack
suggested changes
Apr 25, 2023
alexruzenhack
approved these changes
Apr 26, 2023
r4mmer
force-pushed
the
feat/check-pin-method
branch
from
b795e8e to
8629226
Compare
r4mmer
force-pushed
the
feat/check-pin-method
branch
2 times, most recently
from
aaf5fe3 to
a4e1bc0
Compare
r4mmer
force-pushed
the
feat/check-pin-method
branch
from
a4e1bc0 to
4ae2d0a
Compare
pedroferreira1
approved these changes
May 15, 2023
r4mmer
added a commit
that referenced
this pull request
May 18, 2023
* feat: validate user provided change address (#510) * feat: validate user provided change address * tests: getChangeAddress test * Update src/storage/storage.ts Co-authored-by: Tulio Miranda <tulio.mir@gmail.com> --------- Co-authored-by: Tulio Miranda <tulio.mir@gmail.com> * feat: start generating types when building (#482) * chore: export wallet-service api module (#508) * feat: new method to delete a tx-proposal in wallet-service api (#514) * fix: allow providing pinCode when sending transaction with HathorWalletServiceWallet (#515) * fix: allow providing pinCode when sending transaction with HathorWalletServiceWallet * feat: allow a pinCode to be sent in the old facade sendTransaction method * feat: new token utils (#516) * feat: new token utils * feat: generate access data with account path key (#512) * feat: generate access data with account path key * feat: leveldb dir name (#518) * chore: let access data persist through stops * feat: allow leveldb store on generic dir name * check pin method (#513) * feat: check pin and password methods * feat: wallet id util (#523) * fix created leveldb dir name (#522) * fix: fix test directory name * tests: use walletId util * chore: unnecessary comment * chore: bump version v1.0.0-rc3 (#528) --------- Co-authored-by: Tulio Miranda <tulio.mir@gmail.com> Co-authored-by: Luis Helder <luislhl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Security Checklist