Repository navigation
fix(lint): unbreak main — node:assert/strict → node:assert in bytes-scan-crash test - #1753
Merged
Merged
Conversation
… test The no-restricted-imports rule forbids 'node:assert/strict'; this import (added in 7945918) left lint:required red on main, which reds every downstream PR. 'ok' is identical from 'node:assert', matching all sibling integration tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
Ethan-Arrowood
approved these changes
Jul 10, 2026
Ethan-Arrowood
left a comment
Member
There was a problem hiding this comment.
Fine with this to unblock main, but I'm generally not okay with the switch from node:assert/strict to node:assert. But that is a separate conversation.
sent with Claude Fable 5
cb1kenobi
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integrationTests/resources/bytes-scan-crash.test.ts:26imports{ ok } from 'node:assert/strict', which theno-restricted-importseslint rule forbids. That leftlint:required(runLinter) red onmain—1 problem (1 error)— which surfaces on every downstream PR's CI.The import was added in 7945918 (
fix(table): reject bare-array roots…).okis identical when imported fromnode:assert, which is the form all sibling integration tests already use.Test plan
npm run lint:requiredpasses locally (wasexit 1, nowexit 0)🤖 Generated with Claude Code