Skip to content

fix(lint): unbreak main — node:assert/strict → node:assert in bytes-scan-crash test - #1753

Merged
kriszyp merged 1 commit into
mainfrom
kris/fix-lint-assert-strict
Jul 10, 2026
Merged

kriszyp merged 1 commit into
mainfrom
kris/fix-lint-assert-strict

Conversation

@kriszyp

@kriszyp kriszyp commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

integrationTests/resources/bytes-scan-crash.test.ts:26 imports { ok } from 'node:assert/strict', which the no-restricted-imports eslint rule forbids. That left lint:required (runLinter) red on main — 1 problem (1 error) — which surfaces on every downstream PR's CI.

The import was added in 7945918 (fix(table): reject bare-array roots…). ok is identical when imported from node:assert, which is the form all sibling integration tests already use.

-import { ok } from 'node:assert/strict';
+import { ok } from 'node:assert';

Test plan

  • npm run lint:required passes locally (was exit 1, now exit 0)

🤖 Generated with Claude Code

… test

The no-restricted-imports rule forbids 'node:assert/strict'; this import
(added in 7945918) left lint:required red on main, which reds every
downstream PR. 'ok' is identical from 'node:assert', matching all sibling
integration tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude

claude Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Reviewed; no blockers found.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the import in integrationTests/resources/bytes-scan-crash.test.ts from node:assert/strict to node:assert. There are no review comments, and I have no feedback to provide.

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this to unblock main, but I'm generally not okay with the switch from node:assert/strict to node:assert. But that is a separate conversation.

sent with Claude Fable 5

@kriszyp
kriszyp merged commit a4d999a into main Jul 10, 2026
53 checks passed
@kriszyp
kriszyp deleted the kris/fix-lint-assert-strict branch July 10, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants