fix(serialization): surface @computed scalars on default reads + guard cyclic @enumerable serialization (#1484)

[kriszyp]

Closes #1484.

Default reads now surface non-table @computed attributes, and cyclic @enumerable relationships serialize repeated ancestors as primary-key reference stubs instead of overflowing. The bounded per-table serializer keeps acyclic enumerable tables on a guard-free fast path and uses a path-scoped (table, primary key) guard only when runtime cycles are possible.

The guarded path preserves transport-native values: it identifies both promoted classic msgpackr records and structon random-access records through a shared RecordObject runtime base, recursively materializes only Harper records and ordinary containers, and leaves Date, Buffer/typed arrays, and ArrayBuffer intact for CBOR and MessagePack. Per-encoder record subclasses keep table-specific computed getters isolated.

Reviewer attention: resources/Table.ts owns the cycle guard and guarded materialization; resources/RecordEncoder.ts owns the shared runtime base. A computed resolver's declared scalar type cannot constrain its JS return value, so every surfaced non-table computed takes the guarded path.

Coverage includes mutual/self/runtime-computed cycles, classic msgpackr and structon records, CBOR and MessagePack fidelity, and RocksDB + LMDB. No documentation change is needed: this restores declared computed-field behavior and preserves the existing binary transport contract.

Generated with Claude Opus on the original implementation and Codex on the native-serialization follow-up. Final follow-up review: Gemini 3.6 Flash via direct API found no unresolved issues; the local Claude CLI review route was unavailable (execution timeout).

[gemini-code-assist]

Code Review

This pull request addresses issue #1484 by surfacing computed scalar attributes on default reads and introducing a cycle guard for cyclic-enumerable serialization to prevent stack overflows. The review feedback points out critical issues in the serialization guard implementation, specifically a potential global state leak on error and a crash when serializing composite primary keys containing BigInt values. It also suggests using optional chaining in test assertions to avoid masking server errors.

[claude]

Reviewed; no blockers found.

All 8 prior inline threads are resolved and verified fixed in current code (global-state-leak + BigInt crash guard, object-typed-PK cycle guard, hasSurfacedComputed broadened routing). No new issues found since the last review.

[Ethan-Arrowood]

Code looks right, but the unit failures are this PR's: the basicREST computed-index assertion asserts the pre-fix behavior and needs updating, cache-test's 400 needs a look, and the new test imports node:assert/strict which lint now rejects (#1753). Happy to approve once CI is green.

_{sent with Claude Fable 5}

[kriszyp]

CI was red on 3 things after the rebase — pushed fixes for the two that were real, left the third alone since it's yours to weigh in on:

1. Its own node:assert/strict lint violation in the new computed-and-cyclic-serialization.test.ts — fixed (house rule is node:assert).
2. Two pre-existing tests broke against Fix A's own stated intent, not a code bug:
   • basicREST-test.mjs asserted ageInMonths (a non-enumerable @computed @indexed scalar) stays undefined on a default read — that's exactly the pre-fix behavior this PR's Fix A deliberately changes ("computed scalars... their getters are non-enumerable, so JSON.stringify used to silently drop them... must include"). Updated the assertion to 288 to match.
   • cache-test.mjs's "change source and get" test round-trips a GET response straight into a PUT, stripping only nameTitle before sending it back. Now that ageInMonths also surfaces by default, it rode along and got rejected as a write to a computed attribute (400). Added delete data.ageInMonths alongside the existing strip.

Didn't touch anything else — just wanted CI green so you can review the actual diff without noise. Let me know if you want the ageInMonths default-surfacing behavior itself reconsidered instead of the test updated.

_{— KrAIs (Claude Sonnet 5)}