-
Notifications
You must be signed in to change notification settings - Fork 914
fix bunch of typos and enable codespell via github workflow. #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix bunch of typos and enable codespell via github workflow. #3263
Conversation
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
|
i do not think https://github.com/Haivision/srt/actions/runs/20203155985/job/57997933561?pr=3263 failure is related to this PR?? 🤔 at least i do not see this test failure on my local ubuntu24 machine. |
Pay no attention to it. The version on master still has some random failures of the test, largely related to timing events and incorrect definitions of the test. Most of them have been fixed in the |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
Ok, a general statement for this whole work.
And one more thing: this action should be able to be run manually by a developer, so it would be nice if there's some script that runs it or explains how to install it is added to |
|
@ethouris that i can do, thanks for clarifying that. i'd like to confirm if my understanding is correct.
you mean, against
this PR against
and these are only for |
closes #3262