Skip to content

Conversation

@fujitatomoya
Copy link
Contributor

closes #3262

Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
@fujitatomoya
Copy link
Contributor Author

fujitatomoya commented Dec 14, 2025

i do not think https://github.com/Haivision/srt/actions/runs/20203155985/job/57997933561?pr=3263 failure is related to this PR?? 🤔 at least i do not see this test failure on my local ubuntu24 machine.

@ethouris
Copy link
Collaborator

ethouris commented Dec 14, 2025

i do not think https://github.com/Haivision/srt/actions/runs/20203155985/job/57997933561?pr=3263 failure is related to this PR?? 🤔 at least i do not see this test failure on my local ubuntu24 machine.

Pay no attention to it. The version on master still has some random failures of the test, largely related to timing events and incorrect definitions of the test. Most of them have been fixed in the dev branch, which aims for the next release 1.6.0, but changes are too large to be accommodated for the 1.5.5 release, so don't worry about that. You can request running the test again, until it passes - at least because you haven't changed anything in the code so no worries here.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@ethouris
Copy link
Collaborator

ethouris commented Dec 19, 2025

Ok, a general statement for this whole work.

  1. Spell error fixes that apply to DOCUMENTS (not to the code anywhere), if they can be extracted out of this, are worth adding to the 1.5.5 release, so a separate PR containing only these changes can be prepared and then it can be merged to 1.5.5.
  2. For everything else here, all these changes can only go to the 1.6.0 release, so you need to change the target branch to dev (click "Edit" button at the PR title and select dev branch instead of master).
  3. No new files are allowed in the root directory of the repository. The scripts directory is usually destined for stuff like this, although as all touch upon a specific activity, some additional subdirectory might be in order (e.g. scripts/spellcheck).

And one more thing: this action should be able to be run manually by a developer, so it would be nice if there's some script that runs it or explains how to install it is added to scripts directory.

@fujitatomoya
Copy link
Contributor Author

@ethouris that i can do, thanks for clarifying that. i'd like to confirm if my understanding is correct.

so a separate PR containing only these changes can be prepared and then it can be merged to 1.5.5.

you mean, against master branch only with typo fixes info https://github.com/Haivision/srt/tree/master/docs?

so you need to change the target branch to dev

this PR against dev, includes the fix for master above, correct?

The scripts directory is usually destined for stuff like this, although as all touch upon a specific activity, some additional subdirectory might be in order (e.g. scripts/spellcheck).
And one more thing: this action should be able to be run manually by a developer, so it would be nice if there's some script that runs it or explains how to install it is added to scripts directory.

and these are only for dev, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] Enable automatic spelling checker via github workflow

2 participants