Skip to content

do not add pos for root if none specified for add_root #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leoguignard merged 2 commits into from
Jan 5, 2026
Merged

do not add pos for root if none specified for add_root #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b9831e
do not add pos if none specified for add_root
BadPrograms Dec 10, 2025
66a5751
fix
BadPrograms Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lineagetree/_core/_modifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from collections.abc import Callable, Iterable
from functools import wraps
from typing import TYPE_CHECKING
import numpy as np

if TYPE_CHECKING:
from ..lineage_tree import LineageTree
Expand Down Expand Up @@ -96,7 +97,8 @@ def add_root(lT: LineageTree, t: int, pos: list | None = None) -> int:
lT._successor[C_next] = ()
lT._predecessor[C_next] = ()
lT._time[C_next] = t
lT.pos[C_next] = pos if isinstance(pos, list) else []
if isinstance(pos, (list, tuple)):
lT.pos[C_next] = np.array(pos)
Comment on lines +100 to +101
Copy link
Member

@leoguignard leoguignard Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I forgot but what we do that either all nodes have position or none but no in between

lT._changed_roots = True
return C_next

Expand Down
Loading