do not add pos for root if none specified for add_root #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoguignard
requested changes
Dec 11, 2025
src/lineagetree/_core/_modifier.py
Outdated
Comment on lines
99
to
100
| if isinstance(pos, (list, tuple)): | ||
| lT.pos[C_next] = list(pos) |
Member
There was a problem hiding this comment.
Why do you make the position a list?
The position is forced to be a np.ndarray at construction is there a reason for you to change that here?
Also, if the position is given as a np.ndarray it would not work here, I don't think it's great behaviour.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3.x #95 +/- ##
==========================================
- Coverage 86.46% 86.42% -0.05%
==========================================
Files 20 20
Lines 1810 1812 +2
==========================================
+ Hits 1565 1566 +1
- Misses 245 246 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leoguignard
requested changes
Dec 11, 2025
Comment on lines
+100
to
+101
| if isinstance(pos, (list, tuple)): | ||
| lT.pos[C_next] = np.array(pos) |
Member
There was a problem hiding this comment.
Also, I forgot but what we do that either all nodes have position or none but no in between
leoguignard
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed bug that adds pos of root as an empty list while there should be nothing