feat: emit metrics for exec, verify and render #9078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: configure render, verify, and exec commands to emit metrics * fix: remove render command from tracking due to corrupted output data
* feat: making survey, update, and tracking messages to print to stderr instead of stdout * feat: enable `skaffold render` to track telemetry * feat: remove tests checking if a stadout is set, now we are using stderr * feat: make stderr used to print survey, update, and metricts promp, coloreable to keep same behaviour as stdin * feat: removing IsStdout function and related tests
renzodavid9
changed the title
Codecov Report
@@ Coverage Diff @@
## release/v2.6 #9078 +/- ##
===============================================
Coverage ? 63.61%
===============================================
Files ? 624
Lines ? 31916
Branches ? 0
===============================================
Hits ? 20304
Misses ? 10084
Partials ? 1528 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
ericzzzzzzz
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9073
Description
Cherry pick of #9020 and #9013 for v2.6