Add PullSecretMountPath to ClusterDetails #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2019 13:23
This will give users the option to specify where the pull secret should be mounted within the container. This should fix GoogleContainerTools#731 and enable ECR support.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
tejal29
requested changes
Oct 3, 2019
| @@ -111,6 +111,27 @@ func TestSetDefaultsOnCluster(t *testing.T) { | |||
|
|
|||
| t.CheckNoError(err) | |||
| t.CheckDeepEqual(constants.DefaultKanikoSecretName, cfg.Build.Cluster.PullSecretName) | |||
| t.CheckDeepEqual(constants.DefaultKanikoSecretMountPath, cfg.Build.Cluster.PullSecretMountPath) | |||
There was a problem hiding this comment.
Add a test for when the secret is optional and make sure PullSecretMountPath is not null.
There was a problem hiding this comment.
By "when the secret is optional" do you mean when PullSecret and PullSecretName are not set?
tejal29
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
spoke in person with @priyawadhwa and we decided this is fine for now.
We need to do some further follow up on secret management and documentation for different registries.
Thanks
Tejal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to in case of new feature, this should point to issue/(s) which describes the feature
Fixes #731
Description
This will give users the option to specify where the pull secret should
be mounted within the container. This should fix #731 and enable ECR
support.
User facing changes
n/a
Next PRs.
n/a
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
examplesdir, please copy them tointegration/examplesintegration/examplesdir, should be tested in integration testReviewer Notes