Optional pull secret #2910
Merged
Optional pull secret #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debug mode is also present
prary
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
tejal29
reviewed
Sep 19, 2019
| }, | ||
| } | ||
| if clusterDetails.PullSecretName != "" { |
There was a problem hiding this comment.
this function is becoming really long, can we refactor this into
if clusterDetails.PullSecretName != "" {
vms, vs := getVolumeMountsAndVolumes()
pod.Spec.Containers[0].VolumeMounts = vms
pod.Spec.Volumes = vs
|
@prary do you mind if I add a test to this PR? |
|
@priyawadhwa that would be great :D |
|
Looks like current tests actually cover these changes! I've just refactored the code a little and it should be good to go. |
Codecov Report
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping PR #2897
pull secret should be optional
Resolving issue #2888