Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option in global config to define default kube-contexts #2558

Conversation

corneliusweig
Copy link
Contributor

@corneliusweig corneliusweig commented Jul 26, 2019

See design proposal #2384
Depends on #2447, #2509, and #2555 (all prerequisites have been merged)

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
This command associates a skaffold.yaml with the given kube-context.

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
This command removes an association of a skaffold.yaml with a kube-context.

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@corneliusweig corneliusweig marked this pull request as ready for review August 15, 2019 20:44
@corneliusweig corneliusweig changed the title [WIP] Add option in global config to define default kube-contexts Add option in global config to define default kube-contexts Aug 15, 2019
Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #2558 into master will increase coverage by 0.13%.
The diff coverage is 83.5%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 68% <ø> (-0.26%) ⬇️
cmd/skaffold/app/cmd/config.go 100% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/config/flags.go 100% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/runner.go 67.44% <63.63%> (-1.79%) ⬇️
cmd/skaffold/app/cmd/config/set_context.go 75.6% <75.6%> (ø)
pkg/skaffold/config/util.go 65.55% <81.81%> (+2.26%) ⬆️
pkg/skaffold/schema/profiles.go 88.07% <0%> (-2.4%) ⬇️
pkg/skaffold/server/server.go 58.57% <0%> (ø) ⬆️
pkg/skaffold/util/config.go 78.94% <0%> (+10.52%) ⬆️

@corneliusweig
Copy link
Contributor Author

As discussed in #2510 (comment), the global config option for the kube-context might be an overengineering of the kube-context configurability.

Therefore, I'm going to close this for now to put these changes on hold. If somebody sees an urgent need to get this functionality in, I'm happy to revive this PR. But let's first see how users get along with just the CLI option and the skaffold.yaml option. For now, I'll adjust the design proposal accordingly.

At the very least #2325 is affected.
CC @braderhart, @seblegall @woodcockjosh as you were involved in the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants