-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove #2325
Comments
Why would you like to specify both a kubectl config file and un context? In my understanding, kubectl config file may be managed with 2 strategy :
The ability to specify a file (where a default context is set) should be enough, right? |
@braderhart I see. It seems to me that the use case of having multiple config files and multiple context in each is a little bit particular. Maybe we could start by taking in consideration a specified config file as a first step and see later if there is a need for specifying a context. Then, you've suggested to add this feature in the configuration file In my point of view, the kube config file (or the context) is something that vary depending on the user running skaffold, not depending on the project built with skaffold. In this case, don't you think it should be a CLI flag? |
Hi @braderhart - do you mind writing this up as a design proposal? It sounds like a larger effort that needs some thought. |
@corneliusweig I remember your design proposal #2384 addresses this? |
Hey @tejal29, thanks for highlighting this for me. So to summarize the ideas listed here:
@seblegall @braderhart Please let me know if I missed something. Out of those items, 1), 3) and 5) are addressed by design proposal #2384. It's also implemented, though not merged yet. @braderhart @seblegall You are encouraged to take a look at this and let me know if this is sufficient for your use-cases. As to 2) and 6), I'm totally with @seblegall:
I think it does not make sense to configure a kube-config file in Also, I'm currently -1 for adding another CLI flag for the kubeconfig location. Skaffold already has a lot of CLI options, including 2 flags for configs (skaffold.yaml + skaffold config). Adding a third config file flag will cause massive confusion. Besides, the As to item 4) "configure a default profile for a given Skaffold project" I think it's worth investigating. At the moment, I don't fully understand the use-case, though. In essence, this config permanently changes the main profile to a given profile (in particular, the main profile won't be accessible anymore). However, this effect can be attained in a much cleaner way by restructuring the Do you agree @braderhart? |
Just accidentally wiped out my shared dev environment with skaffold because I forgot to update the kube context. Would love this feature to be completed soon. |
@woodcockjosh I presume you are referring to the context via |
@corneliusweig I'm referring to the kube context. eg |
This should doable now in the next release (v1.1.0 that will come next week) or the bleeding edge https://skaffold.dev/docs/install/, please open an issue if you run into a problem |
"The wages of sin are death; but after they're done taking out taxes, it's just a tired feeling:"
The text was updated successfully, but these errors were encountered: