Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build and release typegen #582

Merged
merged 2 commits into from
Jun 7, 2022
Merged

build and release typegen #582

merged 2 commits into from
Jun 7, 2022

Conversation

mengqiy
Copy link
Contributor

@mengqiy mengqiy commented Jun 7, 2022 •
edited
Loading

Restore some changes that were deleted in #514

  • Restore the typegen related packages go/cmd/typegen and go/pkg/swagger. Moved typegen have its own module in ts/typegen.
  • Restore the typegen release workflow release-typegen.yaml with some necessary changes.
  • Restore the build targets in go/Makefile in ts/typegen/Makefile and also add build and publish support for arm64.

yuwenma
yuwenma reviewed Jun 7, 2022
View reviewed changes
ts/typegen/cmd/main.go Outdated Show resolved Hide resolved
yuwenma
yuwenma approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mengqiy mengqiy merged commit dd7cdf8 into GoogleContainerTools:master Jun 7, 2022
@mengqiy mengqiy deleted the typegenarm branch June 7, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma approved these changes

@droot droot Awaiting requested review from droot

Assignees

@yuwenma yuwenma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mengqiy @yuwenma