-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move typescript code to ts #514
Conversation
yuwenma
commented
Feb 24, 2022
•
edited
Loading
edited
- Move ./go (mainly contains typescript related code) to ./ts
- keep ./go/api (this dir includes Kptfile schema)
- Move ./script (mainly for typescript) to ./ts
- Delete tests/e2e
- Simplify github cicd
- complete cleanup #331
@mengqiy This is ready to review. I removed two required presubmit checks: the e2e tests as we discussed offline and the go-ci which checks ./go. Some other tasks I plan to do in separate PRs
|
IIUC the plan is to use this repo to host TS and golang SDK. The stuff under go/api is not defined in a IDL, it is the golang language binding for Kptfile. What if we have the TS language binding for Kptfile in the future? Where should it live? |
We should revive #331. I don't have bandwidth for it. Can you please pick it up? |
I don't see it. Did I miss anything? |
For sure. |
That is the change "I plan to do in separate PRs". Just want to double check if you have any concerns of removing that from the CI? |
TS, golang and Starlark. kustomize plans to remove starlark support. So we should consider our own starlark support to make it meet the bar for our SDK users. moved to go/api |
I see.
This doesn't sound like a good reason to disable the node CI. Why not just leave it there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, otherwise LGTM
yeah, after renaming those typescript workflow, agree it's better to leave it there. |