Skip to content

Delete unused Datastore region tags / samples. #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2018
Merged

Delete unused Datastore region tags / samples. #292

merged 1 commit into from
Jun 20, 2018

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented Jun 20, 2018 •
edited
Loading

@jmdobry jmdobry requested review from frankyn and ryanmats June 20, 2018 00:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2018
frankyn
frankyn reviewed Jun 20, 2018
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a CL removing these samples?

@jmdobry
Copy link
Member Author

jmdobry commented Jun 20, 2018

They already aren't used on cloud.google.com, hence I'm removing them here.

This was referenced Jun 20, 2018
Merged
Merged
@jmdobry jmdobry changed the title Delete unused Datastore samples. Delete unused Datastore region tags / samples. Jun 20, 2018
This was referenced Jun 20, 2018
Merged
Merged
Merged
Merged
frankyn
frankyn approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@frankyn frankyn merged commit ece33f6 into master Jun 20, 2018
@frankyn frankyn deleted the datastore branch June 20, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@ryanmats ryanmats Awaiting requested review from ryanmats

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmdobry @frankyn @googlebot