Skip to content

Commit ece33f6

Browse files
authored
Merge pull request #292 from GoogleCloudPlatform/datastore
Delete unused Datastore region tags / samples.
2 parents c1e5a3c + 7d63e6e commit ece33f6

File tree

2 files changed

+1
-107
lines changed

2 files changed

+1
-107
lines changed

datastore/sample.rb

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -364,21 +364,7 @@ def keys_only_query
364364
select("__key__")
365365
# [END datastore_keys_only_query]
366366

367-
# [START datastore_run_keys_only_query]
368367
keys = datastore.run(query).map(&:key)
369-
# [END datastore_run_keys_only_query]
370-
end
371-
372-
def distinct_query
373-
datastore = Google::Cloud::Datastore.new
374-
375-
# [START datastore_distinct_query]
376-
query = datastore.query("Task").
377-
select("category", "priority").
378-
distinct_on("category", "priority").
379-
order("category").
380-
order("priority")
381-
# [END datastore_distinct_query]
382368
end
383369

384370
def distinct_on_query
@@ -673,44 +659,3 @@ def property_filtering_run_query
673659
end
674660
# [END datastore_property_filtering_run_query]
675661
end
676-
677-
def gql_run_query
678-
# [START datastore_gql_run_query]
679-
gql_query = Google::Cloud::Datastore::GqlQuery.new
680-
gql_query.query_string = "SELECT * FROM Task ORDER BY created ASC"
681-
tasks = datastore.run gql_query
682-
# [END datastore_gql_run_query]
683-
end
684-
685-
def gql_named_binding_query
686-
# [START datastore_gql_named_binding_query]
687-
gql_query = Google::Cloud::Datastore::GqlQuery.new
688-
gql_query.query_string = "SELECT * FROM Task " \
689-
"WHERE done = @done AND priority = @priority"
690-
gql_query.named_bindings = { done: false, priority: 4 }
691-
# [END datastore_gql_named_binding_query]
692-
693-
gql_query
694-
end
695-
696-
def gql_positional_binding_query
697-
# [START datastore_gql_positional_binding_query]
698-
gql_query = Google::Cloud::Datastore::GqlQuery.new
699-
gql_query.query_string = "SELECT * FROM Task " \
700-
"WHERE done = @1 AND priority = @2"
701-
gql_query.positional_bindings = [false, 4]
702-
# [END datastore_gql_positional_binding_query]
703-
704-
gql_query
705-
end
706-
707-
def gql_literal_query
708-
# [START datastore_gql_literal_query]
709-
gql_query = Google::Cloud::Datastore::GqlQuery.new
710-
gql_query.query_string = "SELECT * FROM Task " \
711-
"WHERE done = false AND priority = 4"
712-
gql_query.allow_literals = true
713-
# [END datastore_gql_literal_query]
714-
715-
gql_query
716-
end

datastore/spec/sample_spec.rb

Lines changed: 1 addition & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -305,24 +305,13 @@ def delete_accounts
305305
expect(percent_completes.first).to eq(10.0)
306306
end
307307

308-
it "supports keys_only_query run_keys_only_query" do
308+
it "supports keys_only_query" do
309309
keys = keys_only_query
310310

311311
expect(keys.empty?).to be(false)
312312
expect(keys.first.kind).to eq("Task")
313313
end
314314

315-
it "supports distinct_query" do
316-
query = distinct_on_query
317-
tasks = datastore.run query
318-
319-
expect(tasks.empty?).to be(false)
320-
expect(tasks.first.key.kind).to eq("Task")
321-
expect(tasks.first["category"]).to eq("Personal")
322-
expect(tasks.first["priority"]).to eq(4)
323-
expect(tasks.first.properties.to_h.size).to eq(2)
324-
end
325-
326315
it "supports distinct_on_query" do
327316
query = distinct_on_query
328317
tasks = datastore.run query
@@ -529,46 +518,6 @@ def delete_accounts
529518
expect(properties_by_kind["Task"]).to include "tag"
530519
end
531520

532-
it "supports gql_run_query" do
533-
tasks = gql_run_query
534-
535-
expect(tasks.empty?).to be(false)
536-
tasks.each { |t| expect_basic_task t }
537-
end
538-
539-
it "supports gql_named_binding_query" do
540-
gql_query = gql_named_binding_query
541-
tasks = datastore.run gql_query
542-
543-
expect(tasks.empty?).to be(false)
544-
tasks.each do |t|
545-
expect_basic_task t
546-
expect(t["priority"]).to eq(4)
547-
end
548-
end
549-
550-
it "supports gql_positional_binding_query" do
551-
gql_query = gql_positional_binding_query
552-
tasks = datastore.run gql_query
553-
554-
expect(tasks.empty?).to be(false)
555-
tasks.each do |t|
556-
expect_basic_task t
557-
expect(t["priority"]).to eq(4)
558-
end
559-
end
560-
561-
it "supports gql_literal_query" do
562-
gql_query = gql_literal_query
563-
tasks = datastore.run gql_query
564-
565-
expect(tasks.empty?).to be(false)
566-
tasks.each do |t|
567-
expect_basic_task t
568-
expect(t["priority"]).to eq(4)
569-
end
570-
end
571-
572521
def expect_basic_task task
573522
expect(task.key.kind).to eq("Task")
574523
expect(task["category"]).to eq("Personal")

0 commit comments

Comments
 (0)