Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete video and logging samples #5020

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

busunkim96
Copy link
Contributor

Deletes logging and videointelligence samples, which have both been moved to client library repositories.

https://github.com/googleapis/python-videointelligence/tree/master/samples
https://github.com/googleapis/python-logging/tree/master/samples

@snippet-bot
Copy link

snippet-bot bot commented Dec 2, 2020

Here is the summary of possible violations 😱

There are 3 possible violations for removing conflicting region tag in use.

Here is the summary of changes.

You deleted 49 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 2, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5bfb41d into master Dec 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the delete-video-and-logging branch December 7, 2020 17:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Dec 7, 2020

@busunkim96 FYI

snippet-bot detected that devsite was (and likely is) still using the region tags in this repository. Some View on Github buttons on https://cloud.google.com/appengine/docs/standard/python/migrate-to-python3/migrate-to-cloud-logging are throwing 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants