Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bigquery/bqml/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ google-cloud-bigquery[pandas,bqstorage]==3.27.0
google-cloud-bigquery-storage==2.27.0
pandas==2.0.3; python_version == '3.8'
pandas==2.2.3; python_version > '3.8'
pyarrow==17.0.0; python_version <= '3.8'
pyarrow==20.0.0; python_version > '3.9'
pyarrow==22.0.0; python_version <= '3.8'
pyarrow==22.0.0; python_version > '3.9'
Comment on lines +5 to +6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These two lines can be simplified. Since they both pin pyarrow to version 22.0.0, they can be combined into a single line. Also, the current version markers (python_version <= '3.8' and python_version > '3.9') create a gap where pyarrow would not be installed for Python 3.9. This is likely unintentional. Other dependencies in this file and related files use python_version > '3.8'. By combining these lines, you can simplify the file and resolve the potential issue for Python 3.9.

pyarrow==22.0.0

flaky==3.8.1
mock==5.1.0
4 changes: 2 additions & 2 deletions bigquery/pandas-gbq-migration/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ pandas==2.2.3; python_version > '3.8'
pandas-gbq==0.24.0
grpcio==1.70.0; python_version == '3.8'
grpcio==1.74.0; python_version > '3.8'
pyarrow==17.0.0; python_version <= '3.8'
pyarrow==20.0.0; python_version > '3.9'
pyarrow==22.0.0; python_version <= '3.8'
pyarrow==22.0.0; python_version > '3.9'
Comment on lines +8 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These two lines can be simplified. Since they both pin pyarrow to version 22.0.0, they can be combined into a single line. The current version markers (python_version <= '3.8' and python_version > '3.9') create a gap where pyarrow would not be installed for Python 3.9. This seems unintentional, especially since other dependencies in this file use markers like python_version > '3.8'. Combining these into a single requirement simplifies the file and ensures pyarrow is installed for all relevant Python versions.

pyarrow==22.0.0

2 changes: 1 addition & 1 deletion bigquery_storage/to_dataframe/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ google-cloud-bigquery===3.30.0; python_version <= '3.8'
google-cloud-bigquery==3.35.1; python_version >= '3.9'
pyarrow===12.0.1; python_version == '3.7'
pyarrow===17.0.0; python_version == '3.8'
pyarrow==21.0.0; python_version >= '3.9'
pyarrow==22.0.0; python_version >= '3.9'
ipython===7.31.1; python_version == '3.7'
ipython===8.10.0; python_version == '3.8'
ipython===8.18.1; python_version == '3.9'
Expand Down