-
Couldn't load subscription status.
- Fork 6.6k
chore(deps): update dependency pyarrow to v22 #13618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update dependency pyarrow to v22 #13618
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, generated by Renovate bot, focuses on updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the pyarrow dependency to version 22.0.0. While this is a straightforward version bump in one file, I've noticed that in bigquery/bqml/requirements.txt and bigquery/pandas-gbq-migration/requirements.txt, the changes introduce some redundancy. I've left comments with suggestions to simplify the pyarrow dependency specification to a single line. This not only makes the requirements.txt files cleaner but also fixes a potential gap in dependency coverage for Python 3.9.
| pyarrow==22.0.0; python_version <= '3.8' | ||
| pyarrow==22.0.0; python_version > '3.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines can be simplified. Since they both pin pyarrow to version 22.0.0, they can be combined into a single line. Also, the current version markers (python_version <= '3.8' and python_version > '3.9') create a gap where pyarrow would not be installed for Python 3.9. This is likely unintentional. Other dependencies in this file and related files use python_version > '3.8'. By combining these lines, you can simplify the file and resolve the potential issue for Python 3.9.
pyarrow==22.0.0
| pyarrow==22.0.0; python_version <= '3.8' | ||
| pyarrow==22.0.0; python_version > '3.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines can be simplified. Since they both pin pyarrow to version 22.0.0, they can be combined into a single line. The current version markers (python_version <= '3.8' and python_version > '3.9') create a gap where pyarrow would not be installed for Python 3.9. This seems unintentional, especially since other dependencies in this file use markers like python_version > '3.8'. Combining these into a single requirement simplifies the file and ensures pyarrow is installed for all relevant Python versions.
pyarrow==22.0.0
|
😱
|
This PR contains the following updates:
==21.0.0->==22.0.0==20.0.0->==22.0.0==17.0.0->==22.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.