Fix issue where errors exporting from the collector are not logged #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
fix_logging
branch
2 times, most recently
from
79ab564
to
a5aa9d2
Compare
Codecov Report
@@ Coverage Diff @@
## main #763 +/- ##
==========================================
- Coverage 69.65% 69.31% -0.35%
==========================================
Files 42 42
Lines 4845 4872 +27
==========================================
+ Hits 3375 3377 +2
- Misses 1321 1344 +23
- Partials 149 151 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aabmass
reviewed
Nov 1, 2023
Comment on lines
+200
to
+205
| if err != nil { | ||
| l.obs.log.Error( | ||
| "Exporting logs failed", | ||
| zap.Error(err), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Should we make a generic wrapper for this kind of thing? Similar to how it worked with retry helper before
There was a problem hiding this comment.
We could write a util function, but it would need access to each logger anyways. Without it being built into the component framework (e.g. like exporterhelper), I don't think we can write a generic wrapper.
|
Closing in favor of open-telemetry/opentelemetry-collector#8792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761
Rather than restore the retry_on_failure component, add logging in the library directly. This has the added advantage of removing the "Try enabling retry_on_failure config option to retry on retryable errors" from the message.