Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collector exporter does not log errors when requests fail #761

Closed
dashpole opened this issue Oct 31, 2023 · 3 comments
Closed

Collector exporter does not log errors when requests fail #761

dashpole opened this issue Oct 31, 2023 · 3 comments
Assignees
@dashpole
Labels
bug Something isn't working priority: p1

Comments

@dashpole
Copy link
Contributor

After removing retry_on_failure in open-telemetry/opentelemetry-collector-contrib#25900, we no longer get any log messages when we fail to send.

Discovered in #760.
@dashpole dashpole added bug Something isn't working priority: p1 labels Oct 31, 2023
@dashpole dashpole self-assigned this Oct 31, 2023
This was referenced Oct 31, 2023
Closed
Closed
@aabmass
Copy link
Contributor

aabmass commented Nov 1, 2023

Looking at the original PR, its very weird that this removed logging. I would have expected the collector to log errors for you even without exporterhelper. Do you think there is an upstream collector bug here?

@dashpole
Copy link
Contributor Author

dashpole commented Nov 1, 2023

Opened open-telemetry/opentelemetry-collector#8791 and open-telemetry/opentelemetry-collector#8792. We can hold off fixing it here until those are resolved.

@dashpole
Copy link
Contributor Author

dashpole commented Nov 2, 2023

Fixed by open-telemetry/opentelemetry-collector#8792

@dashpole dashpole closed this as completed Nov 2, 2023
@dashpole dashpole mentioned this issue Feb 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
bug Something isn't working priority: p1
Projects
None yet
Milestone
No milestone
2 participants
@aabmass @dashpole