-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry span status code does not map directly to google.rpc.Code #143
Closed
aabmass opened this issue
Feb 10, 2021
· 1 comment
· Fixed by #150 or #153 · May be fixed by dshomoye/opentelemetry-collector-contrib#36, hdj630/opentelemetry-collector-contrib#508 or JohnWu20/opentelemetry-collector-contrib#358
Closed
OpenTelemetry span status code does not map directly to google.rpc.Code #143
aabmass opened this issue
Feb 10, 2021
· 1 comment
· Fixed by #150 or #153 · May be fixed by dshomoye/opentelemetry-collector-contrib#36, hdj630/opentelemetry-collector-contrib#508 or JohnWu20/opentelemetry-collector-contrib#358
Comments
aabmass
changed the title
OpenTelemetry span status code does not map directly to google.rcp.Code
OpenTelemetry span status code does not map directly to google.rpc.Code
Feb 12, 2021
Actually on second look, this is not right for opentelemetry-operations-go/exporter/trace/trace_proto.go Lines 120 to 122 in f9b9a4b
|
jsuereth
added a commit
that referenced
this issue
Mar 5, 2021
jsuereth
added a commit
that referenced
this issue
Mar 5, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Found a similar bug in JS and Python exporters (GoogleCloudPlatform/opentelemetry-operations-python#105)
Currently the code's int value is copied into the span pb if it's not
Ok
:opentelemetry-operations-go/exporter/trace/trace_proto.go
Lines 117 to 119 in f9b9a4b
This is fine when it's
Ok
, but the actual error code mapping doesn't make sense:Error Code = 1
CANCELLED = 1
The text was updated successfully, but these errors were encountered: