Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry span status code does not map directly to google.rcp.Code #105

Closed
aabmass opened this issue Feb 10, 2021 · 0 comments · Fixed by #113
Closed

OpenTelemetry span status code does not map directly to google.rcp.Code #105

aabmass opened this issue Feb 10, 2021 · 0 comments · Fixed by #113
Assignees
@aabmass
Labels
bug Something isn't working trace

Comments

@aabmass
Copy link
Collaborator

aabmass commented Feb 10, 2021

OpenTelemetry span status needs to be mapped correctly to GCT's span status (google.rpc.Code). Currently we just copy the int value over:

opentelemetry-operations-python/opentelemetry-exporter-google-cloud/src/opentelemetry/exporter/cloud_trace/__init__.py

Line 225 in 9194ba9

"code": status.status_code.value,

But OTel has OK = 1 but google.rpc.Code has OK = 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aabmass aabmass

Labels
bug Something isn't working trace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Map span status properly to GCT aabmass/opentelemetry-operations-python
1 participant
@aabmass