-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Region Tags #718
Update Region Tags #718
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,15 +13,12 @@ | |
* limitations under the License. | ||
*/ | ||
|
||
// [START app] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto to above - are we still using this? If not, can we delete it? |
||
'use strict'; | ||
|
||
// [START setup] | ||
const express = require('express'); | ||
const errors = require('@google-cloud/error-reporting')(); | ||
|
||
const app = express(); | ||
// [END setup] | ||
|
||
app.get('/', (req, res, next) => { | ||
next(new Error('something is wrong!')); | ||
|
@@ -32,13 +29,10 @@ app.use((err, req, res, next) => { | |
res.status(500).send(err.message || 'Something broke!'); | ||
}); | ||
|
||
// [START listen] | ||
const PORT = process.env.PORT || 8080; | ||
app.listen(PORT, () => { | ||
console.log(`App listening on port ${PORT}`); | ||
console.log('Press Ctrl+C to quit.'); | ||
}); | ||
// [END listen] | ||
// [END app] | ||
|
||
module.exports = app; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,6 @@ | |
|
||
module.exports = function (grunt) { | ||
grunt.initConfig({ | ||
// [START config] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto to above - are we still using this? If not, can we delete it? |
||
jshint: { | ||
files: ['Gruntfile.js', 'src/**/*.js'], | ||
options: { | ||
|
@@ -31,7 +30,6 @@ module.exports = function (grunt) { | |
dest: 'src/public/stylesheets/style.min.css' | ||
} | ||
}, | ||
// [END config] | ||
clean: ['src/public/stylesheets/style.min.css'], | ||
watch: { | ||
js: { | ||
|
@@ -48,12 +46,10 @@ module.exports = function (grunt) { | |
grunt.loadNpmTasks('grunt-contrib-watch'); | ||
grunt.loadNpmTasks('grunt-contrib-clean'); | ||
|
||
// [START tasks] | ||
grunt.loadNpmTasks('grunt-contrib-jshint'); | ||
grunt.loadNpmTasks('grunt-contrib-cssmin'); | ||
|
||
grunt.registerTask('build', ['jshint', 'cssmin']); | ||
// [END tasks] | ||
|
||
grunt.registerTask('default', ['watch']); | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,6 @@ | |
|
||
'use strict'; | ||
|
||
// [START appengine_metadata] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto to above - are we still using this? If not, can we delete it? |
||
const express = require('express'); | ||
const request = require('got'); | ||
|
||
|
@@ -55,4 +54,3 @@ app.listen(PORT, () => { | |
console.log(`App listening on port ${PORT}`); | ||
console.log('Press Ctrl+C to quit.'); | ||
}); | ||
// [END appengine_metadata] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,6 @@ const pass = nconf.get('mongoPass'); | |
const host = nconf.get('mongoHost'); | ||
const port = nconf.get('mongoPort'); | ||
|
||
// [START client] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto to above - are we still using this? If not, can we delete it? |
||
let uri = `mongodb://${user}:${pass}@${host}:${port}`; | ||
if (nconf.get('mongoDatabase')) { | ||
uri = `${uri}/${nconf.get('mongoDatabase')}`; | ||
|
@@ -86,4 +85,3 @@ mongodb.MongoClient.connect(uri, (err, client) => { | |
console.log('started web process'); | ||
}); | ||
}); | ||
// [END client] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,6 @@ | |
|
||
'use strict'; | ||
|
||
// [START app] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto to above - are we still using this? If not, can we delete it? |
||
const express = require('express'); | ||
const nconf = require('nconf'); | ||
const ParseServer = require('parse-server').ParseServer; | ||
|
@@ -46,4 +45,3 @@ app.listen(PORT, () => { | |
console.log(`App listening on port ${PORT}`); | ||
console.log('Press Ctrl+C to quit.'); | ||
}); | ||
// [END app] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this sample not used in the docs anymore? If so, can/should we delete it outright?