New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Region Tags #718

Merged

averikitsch merged 4 commits into GoogleCloudPlatform:master from averikitsch:region-tags-1

Aug 27, 2018

Contributor

averikitsch commented Aug 22, 2018

Ongoing region tag updates/removals
Docs are frozen at last commit


          region tags

b329508

averikitsch requested a review from ace-n

August 22, 2018 23:40

googlebot added the cla: yes label


          Merge branch 'master' into region-tags-1

aaf84ab

codecov bot commented Aug 23, 2018 •

edited

Loading

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files           1        1           
  Lines          58       58           
=======================================
  Hits           32       32           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e6f94...f619dd9. Read the comment docs.

Contributor

ace-n commented Aug 23, 2018

Are the samples without any region tags not used in the docs at all? Or are you trying to include the whole file instead of a specific region?

(If these samples are used somewhere in the docs, I'd argue they should still have region tags - albeit unique ones.)

Contributor Author

averikitsch commented Aug 23, 2018

Right, the removed region tags have no associated doc (and we don't want the sample tracker picking them up). I'm either updating or removing just the tag.


          Merge branch 'master' into region-tags-1

ace-n reviewed

View reviewed changes

Contributor

ace-n left a comment

Region tag changes LGTM, but should we delete some of these samples outright?

appengine/endpoints/app.js

               const express = require('express');
               const bodyParser = require('body-parser');
               const Buffer = require('safe-buffer').Buffer;
               const app = express();
               app.use(bodyParser.json());
-              // [END setup]
               app.post('/echo', (req, res) => {

Contributor

ace-n Aug 27, 2018

Is this sample not used in the docs anymore? If so, can/should we delete it outright?

appengine/grunt/Gruntfile.js

@@ @@ -15,7 +15,6 @@ @@
               module.exports = function (grunt) {
                 grunt.initConfig({
-                  // [START config]

Contributor

ace-n Aug 27, 2018

Ditto to above - are we still using this? If not, can we delete it?

appengine/errorreporting/app.js

@@ @@ -13,15 +13,12 @@ @@
                * limitations under the License.
                */
-              // [START app]

Contributor

ace-n Aug 27, 2018

Ditto to above - are we still using this? If not, can we delete it?

appengine/metadata/standard/server.js

		@@ -15,7 +15,6 @@

		'use strict';

		// [START appengine_metadata]

Contributor

ace-n Aug 27, 2018

Ditto to above - are we still using this? If not, can we delete it?

appengine/mongodb/server.js

@@ @@ -31,7 +31,6 @@ const pass = nconf.get('mongoPass'); @@
               const host = nconf.get('mongoHost');
               const port = nconf.get('mongoPort');
-              // [START client]

Contributor

ace-n Aug 27, 2018

Ditto to above - are we still using this? If not, can we delete it?

appengine/parse-server/server.js

		@@ -15,7 +15,6 @@

		'use strict';

		// [START app]

Contributor

ace-n Aug 27, 2018

Ditto to above - are we still using this? If not, can we delete it?

ace-n approved these changes

View reviewed changes

Contributor

ace-n left a comment

Chatted offline - we'll handle the sample removals in another PR.


          Merge branch 'master' into region-tags-1

f619dd9

averikitsch merged commit 85b1c39 into GoogleCloudPlatform:master

averikitsch deleted the region-tags-1 branch

August 27, 2018 18:00

ace-n pushed a commit that referenced this pull request


          region tags (#718)

c31b283

ahrarmonsur pushed a commit that referenced this pull request


          chore: release 3.4.0 (#782)

aa6798d

🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/nodejs-dialogflow/compare/v3.3.0...v3.4.0) (2021-03-15)


### ⚠ BREAKING CHANGES

* removed ImportAgentResponse which was not ready for use yet

### Features

* add additional_bindings to Dialogflow v2 ListIntents API docs: update copyrights and session docs ([66cd3a5](https://www.github.com/googleapis/nodejs-dialogflow/commit/66cd3a5b5c605deb37efbc4f87edf17b8d4dd4c1))
* add additional_bindings to Dialogflow v2beta1 ListIntents API docs: update copyrights and session docs ([66cd3a5](https://www.github.com/googleapis/nodejs-dialogflow/commit/66cd3a5b5c605deb37efbc4f87edf17b8d4dd4c1))
* add CCAI API ([a93fa71](https://www.github.com/googleapis/nodejs-dialogflow/commit/a93fa71d45cace7822d5585a8a407e3e7e563686))
* added support for regionalization for document API ([#722](https://www.github.com/googleapis/nodejs-dialogflow/issues/722)) ([b6f5738](https://www.github.com/googleapis/nodejs-dialogflow/commit/b6f5738613fc5af49b966d4a8c4137921abed5ef))
* adds style enum ([72bb3ae](https://www.github.com/googleapis/nodejs-dialogflow/commit/72bb3aed5fbe9a605810cce69a12fd3c5e4d1fac))
* allowed custom to specify webhook headers through query parameters ([#724](https://www.github.com/googleapis/nodejs-dialogflow/issues/724)) ([a7f784a](https://www.github.com/googleapis/nodejs-dialogflow/commit/a7f784ac921a750e9df2e6edbfa3bee870187af1))


### Bug Fixes

* **browser:** check for fetch on window ([#718](https://www.github.com/googleapis/nodejs-dialogflow/issues/718)) ([fb28879](https://www.github.com/googleapis/nodejs-dialogflow/commit/fb28879443c27688d1923d6675ea97c3c5d4d0e7))
* do not modify options object, use defaultScopes ([#706](https://www.github.com/googleapis/nodejs-dialogflow/issues/706)) ([95a938d](https://www.github.com/googleapis/nodejs-dialogflow/commit/95a938dbc5f2cc49c217bb5d3cecbbffba3e6d18))
* remove MixedAudio ([a93fa71](https://www.github.com/googleapis/nodejs-dialogflow/commit/a93fa71d45cace7822d5585a8a407e3e7e563686))
* removed ImportAgentResponse which was not ready for use yet ([e0d9fa6](https://www.github.com/googleapis/nodejs-dialogflow/commit/e0d9fa69bba79540c09ec777b3eee6bf0bd5e4b6))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

ahrarmonsur pushed a commit that referenced this pull request


          chore: release 3.4.0 (#782)

f50fda9

🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/nodejs-dialogflow/compare/v3.3.0...v3.4.0) (2021-03-15)


### ⚠ BREAKING CHANGES

* removed ImportAgentResponse which was not ready for use yet

### Features

* add additional_bindings to Dialogflow v2 ListIntents API docs: update copyrights and session docs ([66cd3a5](https://www.github.com/googleapis/nodejs-dialogflow/commit/66cd3a5b5c605deb37efbc4f87edf17b8d4dd4c1))
* add additional_bindings to Dialogflow v2beta1 ListIntents API docs: update copyrights and session docs ([66cd3a5](https://www.github.com/googleapis/nodejs-dialogflow/commit/66cd3a5b5c605deb37efbc4f87edf17b8d4dd4c1))
* add CCAI API ([a93fa71](https://www.github.com/googleapis/nodejs-dialogflow/commit/a93fa71d45cace7822d5585a8a407e3e7e563686))
* added support for regionalization for document API ([#722](https://www.github.com/googleapis/nodejs-dialogflow/issues/722)) ([b6f5738](https://www.github.com/googleapis/nodejs-dialogflow/commit/b6f5738613fc5af49b966d4a8c4137921abed5ef))
* adds style enum ([72bb3ae](https://www.github.com/googleapis/nodejs-dialogflow/commit/72bb3aed5fbe9a605810cce69a12fd3c5e4d1fac))
* allowed custom to specify webhook headers through query parameters ([#724](https://www.github.com/googleapis/nodejs-dialogflow/issues/724)) ([a7f784a](https://www.github.com/googleapis/nodejs-dialogflow/commit/a7f784ac921a750e9df2e6edbfa3bee870187af1))


### Bug Fixes

* **browser:** check for fetch on window ([#718](https://www.github.com/googleapis/nodejs-dialogflow/issues/718)) ([fb28879](https://www.github.com/googleapis/nodejs-dialogflow/commit/fb28879443c27688d1923d6675ea97c3c5d4d0e7))
* do not modify options object, use defaultScopes ([#706](https://www.github.com/googleapis/nodejs-dialogflow/issues/706)) ([95a938d](https://www.github.com/googleapis/nodejs-dialogflow/commit/95a938dbc5f2cc49c217bb5d3cecbbffba3e6d18))
* remove MixedAudio ([a93fa71](https://www.github.com/googleapis/nodejs-dialogflow/commit/a93fa71d45cace7822d5585a8a407e3e7e563686))
* removed ImportAgentResponse which was not ready for use yet ([e0d9fa6](https://www.github.com/googleapis/nodejs-dialogflow/commit/e0d9fa69bba79540c09ec777b3eee6bf0bd5e4b6))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

NimJay pushed a commit that referenced this pull request


          chore: release 3.4.0 (#782)

a0ec663

🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/nodejs-dialogflow/compare/v3.3.0...v3.4.0) (2021-03-15)


### ⚠ BREAKING CHANGES

* removed ImportAgentResponse which was not ready for use yet

### Features

* add additional_bindings to Dialogflow v2 ListIntents API docs: update copyrights and session docs ([66cd3a5](https://www.github.com/googleapis/nodejs-dialogflow/commit/66cd3a5b5c605deb37efbc4f87edf17b8d4dd4c1))
* add additional_bindings to Dialogflow v2beta1 ListIntents API docs: update copyrights and session docs ([66cd3a5](https://www.github.com/googleapis/nodejs-dialogflow/commit/66cd3a5b5c605deb37efbc4f87edf17b8d4dd4c1))
* add CCAI API ([a93fa71](https://www.github.com/googleapis/nodejs-dialogflow/commit/a93fa71d45cace7822d5585a8a407e3e7e563686))
* added support for regionalization for document API ([#722](https://www.github.com/googleapis/nodejs-dialogflow/issues/722)) ([b6f5738](https://www.github.com/googleapis/nodejs-dialogflow/commit/b6f5738613fc5af49b966d4a8c4137921abed5ef))
* adds style enum ([72bb3ae](https://www.github.com/googleapis/nodejs-dialogflow/commit/72bb3aed5fbe9a605810cce69a12fd3c5e4d1fac))
* allowed custom to specify webhook headers through query parameters ([#724](https://www.github.com/googleapis/nodejs-dialogflow/issues/724)) ([a7f784a](https://www.github.com/googleapis/nodejs-dialogflow/commit/a7f784ac921a750e9df2e6edbfa3bee870187af1))


### Bug Fixes

* **browser:** check for fetch on window ([#718](https://www.github.com/googleapis/nodejs-dialogflow/issues/718)) ([fb28879](https://www.github.com/googleapis/nodejs-dialogflow/commit/fb28879443c27688d1923d6675ea97c3c5d4d0e7))
* do not modify options object, use defaultScopes ([#706](https://www.github.com/googleapis/nodejs-dialogflow/issues/706)) ([95a938d](https://www.github.com/googleapis/nodejs-dialogflow/commit/95a938dbc5f2cc49c217bb5d3cecbbffba3e6d18))
* remove MixedAudio ([a93fa71](https://www.github.com/googleapis/nodejs-dialogflow/commit/a93fa71d45cace7822d5585a8a407e3e7e563686))
* removed ImportAgentResponse which was not ready for use yet ([e0d9fa6](https://www.github.com/googleapis/nodejs-dialogflow/commit/e0d9fa69bba79540c09ec777b3eee6bf0bd5e4b6))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This was referenced Jun 20, 2023

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#572

Open

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#601

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels