Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update workflows for ai/ml/data to use labeled on pull_request trigger #3753

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

grayside
Copy link
Collaborator

Description

Scoped to Samples workflows for products in ai-platform, generativeai, dataproc, datalabeling, datacatalog, dlp.

This grouping is trying to find data-intensive tests that take a long time to process so remaining changes have more even test completion times.

Implementation of #3747, sibling of #3748.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jul 22, 2024
@grayside grayside added actions:force-run and removed api: workflows Issues related to the Workflows API. labels Jul 23, 2024
@grayside
Copy link
Collaborator Author

The errors in these failing tests appear to be non-transient: I'm seeing bugs coming from samples and/or tests. As out of scope bugs, they should be non-blocking for this PR.

@grayside grayside marked this pull request as ready for review July 23, 2024 04:40
@grayside grayside requested review from a team as code owners July 23, 2024 04:40
@grayside grayside requested a review from iennae July 23, 2024 04:40
@grayside grayside merged commit 27102d2 into main Jul 26, 2024
45 of 46 checks passed
@grayside grayside deleted the prt-ai-tests branch July 26, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants