Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(functions): update tests to use labeled on pull_request trigger #3748

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

grayside
Copy link
Collaborator

@grayside grayside commented Jul 19, 2024

Description

This change applies the new triggering pattern defined in #3747 to the workflows with filenames prefixed with functions*.

Looking at the checks, there are some big numbers:

  • These workflows are running on pull_request for a number of samples
  • flakybot jobs are skipped in PRs
  • remove-label jobs are skipped when a label isn't used to trigger

In the middle of iterating this PR, I tested using the label trigger. As expected, this double-triggered, because it activated both the pull_request trigger in this PR and the pull_request_target trigger merged to main.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jul 19, 2024
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thank you!

@grayside grayside enabled auto-merge (squash) July 22, 2024 17:09
@grayside grayside added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jul 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 22, 2024
@grayside grayside merged commit 81385a6 into main Jul 22, 2024
323 checks passed
@grayside grayside deleted the prt-functions-tests branch July 22, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants