Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloydb: re-enabled VCR for TestAccAlloydb* tests #12227

Merged
merged 1 commit into from
Nov 1, 2024
Merged

alloydb: re-enabled VCR for TestAccAlloydb* tests #12227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
alloydb: re-enable VCR for TestAccAlloydb* tests 
Fixes hashicorp/terraform-provider-google#16231
  • Loading branch information
@wyardley
wyardley committed Nov 1, 2024
commit b39b6d4af97dfffc7f4e1afcf89e297c1f12aa96
1 change: 0 additions & 1 deletion mmv1/products/alloydb/Backup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ examples:
ignore_read_extra:
- 'reconciling'
- 'update_time'
exclude_test: true
- name: 'alloydb_backup_full_test'
primary_resource_id: 'default'
vars:
Expand Down
5 changes: 0 additions & 5 deletions mmv1/third_party/terraform/services/alloydb/resource_alloydb_secondary_cluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import (
// The cluster creation should succeed with minimal number of arguments
func TestAccAlloydbCluster_secondaryClusterMandatoryFields(t *testing.T) {
t.Parallel()
// https://github.com/hashicorp/terraform-provider-google/issues/16231
acctest.SkipIfVcr(t)
context := map[string]interface{}{
"network_name": acctest.BootstrapSharedServiceNetworkingConnection(t, "alloydbinstance-network-config-1"),
"random_suffix": acctest.RandString(t, 10),
Expand Down Expand Up @@ -152,9 +150,6 @@ data "google_compute_network" "default" {
func TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary(t *testing.T) {
t.Parallel()

// Unskip in https://github.com/hashicorp/terraform-provider-google/issues/16231
acctest.SkipIfVcr(t)

context := map[string]interface{}{
"network_name": acctest.BootstrapSharedServiceNetworkingConnection(t, "alloydbinstance-network-config-1"),
"random_suffix": acctest.RandString(t, 10),
Expand Down
Loading