-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alloydb: re-enabled VCR for TestAccAlloydb*
tests
#12227
alloydb: re-enabled VCR for TestAccAlloydb*
tests
#12227
Conversation
535a932
to
b39b6d4
Compare
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 74 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
I think the unit test failures here are unrelated? |
TestAccAlloydb*
testsTestAccAlloydb*
tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah they are unrelated.
Fixes hashicorp/terraform-provider-google#16231
From this comment, I think these 3 tests can just be re-enabled, unless there's something else specific the owning team has to do?
All 3 of these pass in both recording and replaying mode in my test project, though IIRC, I got a segfault vs. just an error before enabling
servicenetworking
(is there a utility to ensure a specific service is enabled in the default test project). I think you have a way to run this in Teamcity too, which would probably confirm if the test will work there?Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.