Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloydb: re-enabled VCR for TestAccAlloydb* tests #12227

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Nov 1, 2024

Fixes hashicorp/terraform-provider-google#16231

From this comment, I think these 3 tests can just be re-enabled, unless there's something else specific the owning team has to do?

All 3 of these pass in both recording and replaying mode in my test project, though IIRC, I got a segfault vs. just an error before enabling servicenetworking (is there a utility to ensure a specific service is enabled in the default test project). I think you have a way to run this in Teamcity too, which would probably confirm if the test will work there?

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@wyardley wyardley force-pushed the wyardley/issues_16231_alloydb_skip branch from 535a932 to b39b6d4 Compare November 1, 2024 17:50
@github-actions github-actions bot requested a review from hao-nan-li November 1, 2024 17:51
Copy link

github-actions bot commented Nov 1, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/alloydb and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Nov 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 81 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 81 insertions(+), 5 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 74
Passed tests: 69
Skipped tests: 2
Affected tests: 3

Click here to see the affected service packages
  • alloydb

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbBackup_alloydbBackupFullExample
  • TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary
  • TestAccAlloydbCluster_secondaryClusterMandatoryFields

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbBackup_alloydbBackupFullExample [Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary [Debug log]
TestAccAlloydbCluster_secondaryClusterMandatoryFields [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@wyardley
Copy link
Contributor Author

wyardley commented Nov 1, 2024

I think the unit test failures here are unrelated?

@wyardley wyardley changed the title alloydb: re-enable VCR for TestAccAlloydb* tests alloydb: re-enabled VCR for TestAccAlloydb* tests Nov 1, 2024
Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah they are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unskip various TestAccAlloydb* tests in VCR
3 participants