-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: Add Functions tips scopes #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
975d9aa
feat: Add functions_tips_scopes
grant 1ca02d5
Fix: Fix tests by debugging locally
grant 3214b4f
Merge branch 'master' into functions_tips_scopes
grant 8d7ed9c
Update functions/snippets/src/main/java/Scopes.java
grant dfeade2
Merge branch 'master' into functions_tips_scopes
kurtisvg dc96e0c
fix: functions_tips_scopes add util methods
grant fda5069
Merge branch 'master' into functions_tips_scopes
grant 0b62cb4
Update Scopes.java
grant 63d23b8
Merge branch 'master' into functions_tips_scopes
grant dab3b83
Update Scopes.java
grant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Copyright 2019 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
// [START functions_tips_scopes] | ||
|
||
import java.io.IOException; | ||
import java.io.PrintWriter; | ||
import java.util.Arrays; | ||
import javax.servlet.http.HttpServletRequest; | ||
import javax.servlet.http.HttpServletResponse; | ||
|
||
public class Scopes { | ||
// Global (instance-wide) scope | ||
// This computation runs at instance cold-start. | ||
// Warning: Class variables used in Servlet classes must be thread-safe, | ||
// or else might introduce race conditions in your code. | ||
private static final int InstanceVar = heavyComputation(); | ||
|
||
public void scopeDemo(HttpServletRequest request, HttpServletResponse response) | ||
throws IOException { | ||
// Per-function scope | ||
// This computation runs every time this function is called | ||
int functionVar = lightComputation(); | ||
|
||
PrintWriter writer = response.getWriter(); | ||
writer.write(String.format("Instance: %s; function: %s", InstanceVar, functionVar)); | ||
} | ||
|
||
private static int lightComputation() { | ||
int[] numbers = new int[] { 1, 2, 3, 4, 5, 6, 7, 8, 9 }; | ||
return Arrays.stream(numbers).sum(); | ||
} | ||
|
||
private static int heavyComputation() { | ||
int[] numbers = new int[] { 1, 2, 3, 4, 5, 6, 7, 8, 9 }; | ||
return Arrays.stream(numbers).reduce((t, x) -> t * x).getAsInt(); | ||
} | ||
} | ||
|
||
// [END functions_tips_scopes] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.