feat: Add Functions tips scopes #1586
Conversation
googlebot
added
the
cla: yes
|
|
||
| public class Scopes { | ||
| // [END functions_tips_scopes] | ||
| private static int lightComputation() { |
There was a problem hiding this comment.
Since these functions are excluded from the snippet, this snippet is no longer copy-paste-runnable. If you remove the region tag excludes, you can move these functions below scopeDemo so that they are still part of the sample, but the user doesn't have to read them first.
This way the sample is still copy-paste-runnable, but the user doesn't have to read through the functions immediately.
There was a problem hiding this comment.
None of the languages for functions_tips_scopes are copy-paste-runnable.
Do we want to either:
- Keep the sample consistent
- Include these functions but be inconsistent
There was a problem hiding this comment.
We should include these functions. It's fine for older versions of samples to be grandfathered in, but we should aim to keep newer samples up to date with our guidelines, since they were created with the user in mind.
There was a problem hiding this comment.
Included the functions.
There was a problem hiding this comment.
nit: I would still suggest moving them both below scopeDemo (since scopeDemo is really what you want the user to focus on).
There was a problem hiding this comment.
Ah. Moved the functions location to the bottom of the class.
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
|
|
||
| public class Scopes { | ||
| // [END functions_tips_scopes] | ||
| private static int lightComputation() { |
There was a problem hiding this comment.
nit: I would still suggest moving them both below scopeDemo (since scopeDemo is really what you want the user to focus on).
|
Anyone can merge when tests pass. |
Adds a section on Function scopes
Bug: b/132734505
Accidentally closed here: #1561