Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align setup.py and requirements.txt versions #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WarheadsSE
Copy link

Add missing dependencies to setup.py

Add by #62, without the entries in setup.py, pip install gsutil will result in non-functional installation.

File "/usr/local/lib/python3.9/site-packages/gcs_oauth2_boto_plugin/oauth2_client.py", line 57, in <module>
  from google_auth_httplib2 import Request as GoogleAuthRequest
ModuleNotFoundError: No module named 'google_auth_httplib2'

Update requirements.txt versions to align with setup.py for six

I noticed that these two did not agreed on the version of six, either, so I addressed that.

Closes #67

Copy link

google-cla bot commented May 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@WarheadsSE
Copy link
Author

CLA addressed, check needs re-run.

- Add missing dependencies to setup.py
- Update requirements.txt versions to align with setup.py

Signed-off-by: Jason Plum <max@warheads.net>
@googlyrahman
Copy link
Member

Hi, I understand that this would be an issue with standalone plugin, but i want to understand how this is the problem with gsutil installation, as gsutil setup.py (https://github.com/GoogleCloudPlatform/gsutil/blob/master/setup.py#L55) consists of these dependencies. I've also tried doing a fresh installation on a fresh VM, and it works perfectly fine, as gsutil setup.py has those dependency.

@googlyrahman
Copy link
Member

googlyrahman commented May 2, 2024

Thanks for bringing this to our attention, We were also discussing this internally, and decided to fix it.

@WarheadsSE
Copy link
Author

Hi, I understand that this would be an issue with standalone plugin, but i want to understand how this is the problem with gsutil installation, as gsutil setup.py (https://github.com/GoogleCloudPlatform/gsutil/blob/master/setup.py#L55) consists of these dependencies.

Put simply, you are correct. As of 2 weeks ago, master of gsutil did indeed include that dependency. However, anyone who installed a version prior to that point in time, would have a floating dependency on this package, which would not have declared a functional requirement.

@stanhu
Copy link

stanhu commented May 2, 2024

For example, if you had run pip install gsutil==5.27 prior to the release of gcs-oauth2-boto-plugin v3.2, then you would run into this issue.

@WarheadsSE
Copy link
Author

@googlyrahman @shilpi23pandey I have left this open, for the time being, in regards to change in requirements.txt. Consider it a reminder to address that.

#70 effectively took the changes from here, and #68, but placed them under different lines, and with your internal team as the author(s).

@shilpi23pandey
Copy link
Member

@googlyrahman @shilpi23pandey I have left this open, for the time being, in regards to change in requirements.txt. Consider it a reminder to address that.

#70 effectively took the changes from here, and #68, but placed them under different lines, and with your internal team as the author(s).

Hi @WarheadsSE This issue was blocking a critical gsutil release which was raised internally so we had to take action ASAP. For the sake of time, we decided to fix it ourselves.

That said, thanks for the PR and logging the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing google-auth-* in setup.py
4 participants