Removed dependency of openSSL for authentication with .p12 keys #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilpi23pandey
approved these changes
Apr 26, 2024
sushantkhanna
approved these changes
Apr 29, 2024
stanhu
added a commit
to stanhu/gcs-oauth2-boto-plugin
that referenced
this pull request
May 1, 2024
GoogleCloudPlatform#62 added these dependencies to `requirements.txt`, but neglected to include them in `setup.py`. As a result, installing `pip install gsutil` doesn't automatically install these dependencies, resulting in: ``` File "/usr/local/lib/python3.9/site-packages/gcs_oauth2_boto_plugin/oauth2_client.py", line 57, in <module> from google_auth_httplib2 import Request as GoogleAuthRequest ModuleNotFoundError: No module named 'google_auth_httplib2' ``` Closes GoogleCloudPlatform#67
stanhu
added a commit
to stanhu/gcs-oauth2-boto-plugin
that referenced
this pull request
May 1, 2024
GoogleCloudPlatform#62 added these dependencies to `requirements.txt`, but neglected to include them in `setup.py`. As a result, installing `pip install gsutil` doesn't automatically install these dependencies, resulting in: ``` File "/usr/local/lib/python3.9/site-packages/gcs_oauth2_boto_plugin/oauth2_client.py", line 57, in <module> from google_auth_httplib2 import Request as GoogleAuthRequest ModuleNotFoundError: No module named 'google_auth_httplib2' ``` Closes GoogleCloudPlatform#67 Signed-off-by: Stan Hu <stanhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Results = https://paste.googleplex.com/6510605917224960
Removed dependency of openSSL for authentication with .p12 keys