Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor updates for lint #694

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: minor updates for lint #694

merged 1 commit into from
Aug 29, 2024

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Aug 28, 2024 •
edited
Loading

Description

  • remove unused data and variables (and associated plumbing)
  • add version constraints
  • minor terraform updates

@dpebot
Copy link
Collaborator

dpebot commented Aug 28, 2024

/gcbrun

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 28, 2024
@apeabody apeabody marked this pull request as ready for review August 28, 2024 20:08
@apeabody apeabody requested review from yoshi-approver and a team as code owners August 28, 2024 20:08
@apeabody apeabody requested a review from NimJay August 28, 2024 20:08
@apeabody
Copy link
Collaborator Author

@NimJay Includes #692 (comment)

@apeabody apeabody mentioned this pull request Aug 28, 2024
Merged
NimJay
NimJay approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @apeabody! Everything looks good. Approved.
Feel free to merge whenever.

@apeabody apeabody merged commit 083e792 into GoogleCloudPlatform:main Aug 29, 2024
14 checks passed
@release-please release-please bot mentioned this pull request Aug 29, 2024
Closed
@apeabody apeabody deleted the ap/lint branch August 29, 2024 15:52
@apeabody apeabody mentioned this pull request Sep 25, 2024
Closed
@release-please release-please bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeabody @dpebot @NimJay