Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anthos-attached-clusters): add providers and lint #692

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix(anthos-attached-clusters): add providers and lint #692

merged 2 commits into from
Aug 28, 2024

Conversation

apeabody
Copy link
Collaborator

Description

  • Add any missing providers and versions constraints
  • Additional lint fixes

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 27, 2024
@dpebot
Copy link
Collaborator

dpebot commented Aug 27, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Aug 28, 2024

/gcbrun

@apeabody apeabody marked this pull request as ready for review August 28, 2024 17:24
@apeabody apeabody requested review from yoshi-approver and a team as code owners August 28, 2024 17:24
@apeabody apeabody requested a review from linde August 28, 2024 17:24
NimJay
NimJay approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @apeabody! Approved. Feel free to merge whenever you're comfortable!

@apeabody apeabody merged commit 393d625 into GoogleCloudPlatform:main Aug 28, 2024
14 checks passed
@apeabody apeabody deleted the ap/attached-lint branch August 28, 2024 18:04
@apeabody apeabody mentioned this pull request Aug 28, 2024
Merged
This was referenced Sep 25, 2024
Closed
Closed
@release-please release-please bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

@linde linde Awaiting requested review from linde

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeabody @dpebot @NimJay