[DO NOT MERGE] Making LTs run on templates built from current code

[darshan-sj]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @darshan-sj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant improvements to the Dataflow Flex Template load testing framework. By modifying the FlexTemplateDataflowJobResourceManager to accept an injected PipelineLauncher, it enables more controlled and customizable template launches. This change is then propagated to several load test base classes, simplifying their configuration logic and making them more adaptable for testing templates built from the current codebase. The overall impact is a more robust and maintainable load testing infrastructure.

Highlights

• Enhanced FlexTemplateDataflowJobResourceManager: The FlexTemplateDataflowJobResourceManager now supports injecting a PipelineLauncher instance during its construction, providing greater flexibility for custom pipeline launching scenarios.
• Simplified Load Test Configuration: The load test base classes (DataStreamToSpannerLTBase, SourceDbToSpannerLTBase, SpannerToSourceDbLTBase) have been refactored to leverage the enhanced FlexTemplateDataflowJobResourceManager.Builder. This streamlines the process of setting template parameters and environment variables.
• Removal of Redundant Code: The SourceDbToSpannerLTBase class saw the removal of the ADDITIONAL_JOB_PARAMS static map, simplifying its structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.88%. Comparing base (94170b6) to head (3f75e4d).

Files with missing lines	Patch %	Lines
...taflow/FlexTemplateDataflowJobResourceManager.java	0.00%	6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3270      +/-   ##
============================================
- Coverage     50.88%   50.88%   -0.01%     
- Complexity     5165     5545     +380     
============================================
  Files           978      978              
  Lines         60455    60460       +5     
  Branches       6617     6618       +1     
============================================
  Hits          30764    30764              
- Misses        27529    27534       +5     
  Partials       2162     2162              

Components	Coverage Δ
spanner-templates	70.84% <ø> (ø)
spanner-import-export	68.92% <ø> (ø)
spanner-live-forward-migration	80.10% <ø> (ø)
spanner-live-reverse-replication	77.61% <ø> (ø)
spanner-bulk-migration	88.07% <ø> (ø)

Files with missing lines	Coverage Δ
...taflow/FlexTemplateDataflowJobResourceManager.java	21.69% <0.00%> (-1.08%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.