Skip to content

Conversation

@darshan-sj
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @darshan-sj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Dataflow Flex Template launching mechanism within the integration test framework. By introducing the ability to inject a PipelineLauncher into the FlexTemplateDataflowJobResourceManager and updating various load test base classes to use this enhanced builder, the PR ensures that load tests can be executed against templates compiled from the most current source code. This improves the reliability and relevance of load testing by validating the exact code being developed.

Highlights

  • Enhanced FlexTemplateDataflowJobResourceManager: The FlexTemplateDataflowJobResourceManager now allows for an external PipelineLauncher to be injected during its construction, providing greater flexibility for testing scenarios.
  • New getLaunchConfig method: A new getLaunchConfig() method has been added to FlexTemplateDataflowJobResourceManager to retrieve the configuration used for launching a job.
  • Refactored Load Test Base Classes: Load test base classes for DataStreamToSpanner, SourceDbToSpanner, and SpannerToSourceDb templates have been updated to utilize the new FlexTemplateDataflowJobResourceManager.Builder for launching Dataflow jobs. This change streamlines how template parameters and environment variables are set.
  • Enabling Current Code Testing for LTs: These changes collectively enable load tests (LTs) to run against templates built directly from the current codebase, ensuring that the latest template logic is validated during testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@darshan-sj darshan-sj marked this pull request as ready for review January 28, 2026 17:41
@darshan-sj darshan-sj requested a review from a team as a code owner January 28, 2026 17:41
@darshan-sj darshan-sj requested review from manitgupta and sm745052 and removed request for a team January 28, 2026 17:41
@darshan-sj darshan-sj merged commit 3f75e4d into GoogleCloudPlatform:lt-on-current-code Jan 28, 2026
3 of 5 checks passed
pratickchokhani pushed a commit to pratickchokhani/DataflowTemplates that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant