Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 21, 2025

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.74%. Comparing base (a2779d4) to head (e56d324).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2142      +/-   ##
============================================
- Coverage     46.74%   46.74%   -0.01%     
+ Complexity     3977     3976       -1     
============================================
  Files           873      873              
  Lines         51871    51871              
  Branches       5429     5429              
============================================
- Hits          24248    24247       -1     
  Misses        25897    25897              
- Partials       1726     1727       +1     
Components Coverage Δ
spanner-templates 68.63% <ø> (-0.01%) ⬇️
spanner-import-export 65.57% <ø> (-0.02%) ⬇️
spanner-live-forward-migration 76.49% <ø> (ø)
spanner-live-reverse-replication 78.39% <ø> (ø)
spanner-bulk-migration 87.87% <ø> (ø)

see 1 file with indirect coverage changes

@liferoad
Copy link
Contributor

liferoad commented Jan 22, 2025

This happened before (https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/12877500595), which should not be caused by this PR.

2025-01-21 23:28:09 5.14.0 WARNING Failed to get OTEL, will skip exporting client side metrics 
java.lang.NoClassDefFoundError: io/opentelemetry/api/incubator/trace/ExtendedTracer
	at io.opentelemetry.sdk.trace.SdkTracerProvider.<init>(SdkTracerProvider.java:56)
	at io.opentelemetry.sdk.trace.SdkTracerProviderBuilder.build(SdkTracerProviderBuilder.java:212)
	at io.opentelemetry.sdk.OpenTelemetrySdkBuilder.build(OpenTelemetrySdkBuilder.java:101)
	at com.google.cloud.bigtable.data.v2.stub.metrics.DefaultMetricsProvider.getOpenTelemetry(DefaultMetricsProvider.java:51)
	at com.google.cloud.bigtable.data.v2.stub.EnhancedBigtableStub.getOpenTelemetry(EnhancedBigtableStub.java:393)
	at com.google.cloud.bigtable.data.v2.stub.EnhancedBigtableStub.create(EnhancedBigtableStub.java:223)
	at com.google.cloud.bigtable.data.v2.stub.BigtableChannelPrimer.sendPrimeRequests(BigtableChannelPrimer.java:90)
	at com.google.cloud.bigtable.data.v2.stub.BigtableChannelPrimer.primeChannelUnsafe(BigtableChannelPrimer.java:78)
	at com.google.cloud.bigtable.data.v2.stub.BigtableChannelPrimer.primeChannel(BigtableChannelPrimer.java:70)
	at com.google.api.gax.grpc.InstantiatingGrpcChannelProvider.createSingleChannel(InstantiatingGrpcChannelProvider.java:444)
	```

@Abacn
Copy link
Contributor Author

Abacn commented Jan 22, 2025

CassandraToBigtableIT failed not related to the change. merging for now.

@Abacn Abacn merged commit 409a5cc into GoogleCloudPlatform:main Jan 22, 2025
12 of 14 checks passed
@Abacn Abacn deleted the downgradereq branch January 22, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants