-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Switch to Java 17 for all Dataflow Templates #2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
============================================
- Coverage 46.58% 46.58% -0.01%
+ Complexity 3960 3950 -10
============================================
Files 869 867 -2
Lines 51599 51550 -49
Branches 5403 5398 -5
============================================
- Hits 24036 24012 -24
+ Misses 25844 25820 -24
+ Partials 1719 1718 -1
|
|
there is a single test failure from the report: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/2050/checks?check_run_id=33950822829 This is expected. The original assert was too strict, see https://stackoverflow.com/questions/77305259/change-in-gzipoutputstream-behavior-in-java-17 |
|
Kafka PR running on https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/12183265029 Spanner PR running on https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/12183272085 |
|
TODO: fix #2050 (comment) |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just have a minor comment, could be follow up (so no need to push new commit that triggers all tests)
...cloud-platform/src/main/java/org/apache/beam/it/gcp/artifacts/matchers/ArtifactsSubject.java
Show resolved
Hide resolved
Done. |
|
Thanks, all Spanner PR are passing - https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/12183272085 |
manitgupta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #2051