Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Nov 14, 2024

No description provided.

@Abacn
Copy link
Contributor Author

Abacn commented Nov 15, 2024

LocalSpannerIO again causing conflict:

Error:  /home/runner/actions-runner/_work/DataflowTemplates/DataflowTemplates/v1/src/main/java/org/apache/beam/sdk/io/gcp/spanner/LocalSpannerIO.java:[28,63] cannot find symbol
Error:    symbol:   class NameGenerator
Error:    location: package org.apache.beam.sdk.io.gcp.spanner.changestreams

we should proceed #1429

@Abacn
Copy link
Contributor Author

Abacn commented Nov 15, 2024

This line becomes problematic after the upstream change:

WithKeys.<BigQueryTablePartition, String>of((BigQueryTablePartition) null)

It explicitly set a null value here, but after apache/beam#32705 , the inferred schema assumes not-null

@codecov
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 44.99%. Comparing base (7fed825) to head (57f9bd9).
Report is 112 commits behind head on main.

Files with missing lines Patch % Lines
...apache/beam/sdk/io/gcp/spanner/LocalSpannerIO.java 0.00% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2014      +/-   ##
============================================
- Coverage     45.41%   44.99%   -0.42%     
+ Complexity     3675     3637      -38     
============================================
  Files           842      842              
  Lines         49970    49973       +3     
  Branches       5261     5261              
============================================
- Hits          22692    22484     -208     
- Misses        25608    25834     +226     
+ Partials       1670     1655      -15     
Components Coverage Δ
spanner-templates 66.72% <ø> (+<0.01%) ⬆️
spanner-import-export 64.20% <ø> (+0.02%) ⬆️
spanner-live-forward-migration 75.88% <ø> (ø)
spanner-live-reverse-replication 76.65% <ø> (ø)
spanner-bulk-migration 86.37% <ø> (ø)
Files with missing lines Coverage Δ
...ogle/cloud/teleport/v2/templates/MqttToPubsub.java 15.62% <ø> (ø)
...apache/beam/sdk/io/gcp/spanner/LocalSpannerIO.java 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

@Abacn
Copy link
Contributor Author

Abacn commented Nov 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant