Basic Changes to use Upstream Cassandra io for Bulk Cassandra Migration #2129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
============================================
+ Coverage 46.62% 54.90% +8.27%
+ Complexity 3953 1595 -2358
============================================
Files 867 405 -462
Lines 51567 21825 -29742
Branches 5399 2157 -3242
============================================
- Hits 24043 11982 -12061
+ Misses 25808 9146 -16662
+ Partials 1716 697 -1019
|
Deep1998
reviewed
Jan 13, 2025
...port/v2/source/reader/io/cassandra/iowrapper/CassandraTableReaderFactoryCassandraIoImpl.java
Show resolved
Hide resolved
Deep1998
approved these changes
Jan 14, 2025
VardhanThigle
merged commit 8217f1a
into
GoogleCloudPlatform:main
15 of 16 checks passed
darshan-sj
pushed a commit
that referenced
this pull request
Jan 15, 2025
…on (#2129) * Cassandra Table Reader Factory * Completing TODO for Cassandra IOWrapper
pawankashyapollion
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 15, 2025
…on (GoogleCloudPlatform#2129) * Cassandra Table Reader Factory * Completing TODO for Cassandra IOWrapper
akashthawaitcc
pushed a commit
to ollionorg/DataflowTemplates-fork
that referenced
this pull request
Jan 23, 2025
…on (GoogleCloudPlatform#2129) * Cassandra Table Reader Factory * Completing TODO for Cassandra IOWrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a Child #2114 , which has the basic changes to enable using UpstreamCassandraIO for bulk Read.
This also has a UT with embedded Cassandra where a read is performed on a table with few rows and all primitive types.