Upgrade Workbox to v4.0.0-alpha.0 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In regards to the changes needed to update He also noted that overriding the default router still requires a bit of work to get it to behave as we want here. Overriding the default router in Workbox (v3) was first proposed in #5 (comment) This change will be documented as part of the release notes in v4. |
westonruter
changed the title
miina
approved these changes
Oct 30, 2018
This was referenced Oct 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #97.
Updating to v4.0.0-alpha.0 is good for testing the release, and it is also needed for offline commenting (#87/#92).
This PR also eliminates storing Workbox in a version-specific directory (as output by
workbox copyLibraries). This will make diffing between Workbox versions more sane.This needs to be fixed before it can be merged: