Use newly-public routes property on Router class instead of private one #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on GoogleChrome/workbox#1747 |
westonruter
changed the title
…m-router-lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #98.
This will fix this error being raised when using production build of Workbox:
This error is caused by the production version of Workbox munging the
_routesproperty of theRouterclass:https://github.com/xwp/pwa-wp/blob/1efb6a9243f2e1a1eaab264d8f1fe82e3d029831/wp-includes/js/service-worker.js#L25
Workbox v4 will make this private
_routesinto publicroutes. When this happens upstream, this PR needs to be updated with the new build.