Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(driver): don't await cleanup in PAGE_HUNG case #15833

Merged
merged 1 commit into from
Feb 26, 2024
Merged

core(driver): don't await cleanup in PAGE_HUNG case #15833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/gather/driver/wait-for-condition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,10 @@
log.warn('waitFor', 'Timed out waiting for page load. Checking if page is hung...');
if (await isPageHung(session)) {
log.warn('waitFor', 'Page appears to be hung, killing JavaScript...');
await session.sendCommand('Emulation.setScriptExecutionDisabled', {value: true});
await session.sendCommand('Runtime.terminateExecution');
// We don't await these, as we want to exit with PAGE_HUNG
void session.sendCommand('Emulation.setScriptExecutionDisabled', {value: true})
.catch(_ => {});
void session.sendCommand('Runtime.terminateExecution').catch(_ => {});

Check warning on line 503 in core/gather/driver/wait-for-condition.js

View check run for this annotation

Codecov / codecov/patch

core/gather/driver/wait-for-condition.js#L500-L503 

Added lines #L500 - L503 were not covered by tests
throw new LighthouseError(LighthouseError.errors.PAGE_HUNG);
}

Expand Down
Loading