Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(driver): don't await cleanup in PAGE_HUNG case #15833

Merged
merged 1 commit into from
Feb 26, 2024
Merged

core(driver): don't await cleanup in PAGE_HUNG case #15833

merged 1 commit into from
Feb 26, 2024

Conversation

paulirish
Copy link
Member

Also discovered during the targetcrashed journey (#11840)

@paulirish paulirish requested a review from a team as a code owner February 26, 2024 22:01
@paulirish paulirish requested review from connorjclark and removed request for a team February 26, 2024 22:01
connorjclark
connorjclark approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@connorjclark connorjclark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

alt: wanna make a session.sendCommandAndIgnore or sumthing to do the same? then the comment becomes unnecessary IMO (or can go in that function jsdoc for why you'd wanna use it). and it can return void so we don't gotta do void ...

@paulirish
Copy link
Member Author

make a session.sendCommandAndIgnore or sumthing to do the same?

cool idea. looks like we employ this pattern quite a bit.

@paulirish paulirish merged commit f0e144c into main Feb 26, 2024
29 checks passed
@paulirish paulirish deleted the pagehungvoid branch February 26, 2024 23:14
@paulirish paulirish mentioned this pull request Apr 3, 2024
Merged
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees

@connorjclark connorjclark

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulirish @connorjclark @devtools-bot